Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EXPLICIT_INSTANTIATE_ONLY macros #358

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

achirkin
Copy link
Contributor

CUVS_EXPLICIT_INSTANTIATE_ONLY macro carried over from raft; it is not very useful in the fully compiled library, such as cuVS, hence is removed.

@achirkin achirkin added bug Something isn't working non-breaking Introduces a non-breaking change labels Sep 27, 2024
@achirkin
Copy link
Contributor Author

achirkin commented Oct 1, 2024

I've checked the build artifacts of this branch against the latest state of branch-24.10.
The cuda12_x86_x64 libcuvs.so file is 40 bytes larger in the PR version than the base-24.10, I'm not sure why. I've checked the contents with nm and diff tools; after stripping the symbol addresses, the outputs of nm are identical (hence no extra instances defined).
With that in mind, I am rather confident that the PR does not indeed affect any functionality or compiling behavior. @cjnolet , I'd suggest we have an option to merge this in 24.10 if you're feeling like doing so.

@achirkin achirkin marked this pull request as ready for review October 1, 2024 08:51
@achirkin achirkin requested review from a team as code owners October 1, 2024 08:51
@cjnolet
Copy link
Member

cjnolet commented Oct 2, 2024

@achirkin I missed your comment here for some reason. I'm not opposed to merging this for 24.10, so long as we can get it through CI in time. I slated it for 24.10 in the meantime.

@cjnolet
Copy link
Member

cjnolet commented Oct 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit 67684ba into rapidsai:branch-24.10 Oct 2, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake cpp non-breaking Introduces a non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

2 participants