Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port remaining scripts to cuvs_bench #368

Merged
merged 32 commits into from
Oct 4, 2024
Merged

Port remaining scripts to cuvs_bench #368

merged 32 commits into from
Oct 4, 2024

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Oct 1, 2024 •
edited
Loading

Builds upon #367

@divyegala divyegala added feature request New feature or request non-breaking Introduces a non-breaking change labels Oct 1, 2024
@divyegala divyegala requested review from a team as code owners October 1, 2024 20:28
@divyegala divyegala requested a review from bdice October 1, 2024 20:28
bdice
bdice reviewed Oct 1, 2024
View reviewed changes
build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
ci/build_python.sh Outdated Show resolved Hide resolved
conda/recipes/cuvs_bench/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/cuvs_bench/meta.yaml Show resolved Hide resolved
python/cuvs_bench/cuvs_bench/generate_groundtruth/__main__.py Outdated Show resolved Hide resolved
python/cuvs_bench/cuvs_bench/generate_groundtruth/utils.py Outdated Show resolved Hide resolved
python/cuvs_bench/cuvs_bench/generate_groundtruth/utils.py Outdated Show resolved Hide resolved
python/cuvs_bench/cuvs_bench/get_dataset/fbin_to_f16bin.py Outdated Show resolved Hide resolved
python/cuvs_bench/cuvs_bench/split_groundtruth/split_groundtruth.pl Show resolved Hide resolved
@divyegala
Copy link
Member Author

@bdice thanks for the review! This PR builds upon #367 so I applied relevant review suggestions to the diff over there

@divyegala divyegala requested a review from a team as a code owner October 2, 2024 20:37
cjnolet
cjnolet requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some references to raft have been missed in this PR.

cpp/cmake/thirdparty/get_cuvs.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_cuvs.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_cuvs.cmake Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_cuvs.cmake Outdated Show resolved Hide resolved
python/cuvs_bench/cuvs_bench/generate_groundtruth/__main__.py Outdated Show resolved Hide resolved
python/cuvs_bench/cuvs_bench/generate_groundtruth/__main__.py Outdated Show resolved Hide resolved
@cjnolet cjnolet mentioned this pull request Oct 3, 2024
Closed
@divyegala
Copy link
Member Author

@bdice can you approve this PR in lieu of #367 ?

@cjnolet
Copy link
Member

cjnolet commented Oct 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit b754166 into rapidsai:branch-24.10 Oct 4, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@divyegala divyegala

Labels
ci CMake cpp feature request New feature or request non-breaking Introduces a non-breaking change Python
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@divyegala @cjnolet @bdice @dantegd