disallow fallback to Make in Python builds #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jameslamb
commented
Jan 31, 2025
| @@ -397,7 +397,7 @@ dependencies: | |||
| - *libcusparse114 | |||
| cuda_wheels: | |||
| specific: | |||
| - output_types: pyproject | |||
| - output_types: [requirements, pyproject] | |||
There was a problem hiding this comment.
This should be fine, for the reasons mentioned in https://github.com/rapidsai/raft/pull/2563/files#r1938056656
jameslamb
changed the title
|
/ok to test |
jameslamb
changed the title
bdice
approved these changes
Feb 3, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#146
Proposes:
[tool.scikit-build].ninja.make-fallback = false, soscikit-build-corewill not silently fallback to using GNU Make ifninjais not availabledependencies.yamlwithoutput_types: pyprojectinoutput_types: requirementsas well.