ConfigureCUDA.cmake now sets CUVS_ prefixed variables #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ci failures fixed in rapidsai/raft#2254 |
bdice
reviewed
Apr 3, 2024
cjnolet
added
improvement
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Apr 10, 2024
The init order of class members needs to follow the order listed in the class. This corrects the error for the cagra index type, as it was found to be wrong via rapidsai/cuvs#66 Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #2254
bdice
approved these changes
Apr 10, 2024
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
robertmaynard
force-pushed
the
bug/configure_cuda_set_correct_vars
branch
from
13167bc
to
13ef7ec
Compare
cjnolet
approved these changes
May 17, 2024
|
/merge |
difyrrwrzd
added a commit
to difyrrwrzd/cuvs
that referenced
this pull request
Aug 10, 2024
This makes sure that CUVS uses the compile flags that are required for RAPIDS C++ projects. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that CUVS uses the compile flags that are required for RAPIDS C++ projects.