Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop setup.py #1354

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Drop setup.py #1354

merged 1 commit into from
Jul 1, 2024

Conversation

jakirkham
Copy link
Member

This is just calling setup from setuptools, which should already happen with the setuptools backend. So go ahead and drop setup.py.

@jakirkham
Drop setup.py
82c4131 
This is just calling `setup` from `setuptools`, which should already
happen with the `setuptools` backend. So go ahead and drop `setup.py`.
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 28, 2024
@jakirkham jakirkham requested a review from jameslamb June 28, 2024 22:56
pentschev
pentschev approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jakirkham .

jameslamb
jameslamb approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks!

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 3e0f7c3 into rapidsai:branch-24.08 Jul 1, 2024
28 checks passed
@jakirkham jakirkham deleted the drop_setup_py branch July 1, 2024 16:46
@jakirkham
Copy link
Member Author

Thank you both! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakirkham @jameslamb @pentschev