Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CuPy benchmark with more operations #488

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

pentschev
Copy link
Member

No description provided.

@pentschev pentschev requested a review from a team as a code owner January 6, 2021 17:22
@pentschev pentschev added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 6, 2021
Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pentschev -- should I add this to the nightly runs ?

@pentschev
Copy link
Member Author

Thanks @pentschev -- should I add this to the nightly runs ?

I think that's not necessary for now, I'm mostly adding this as part of the PTDS work, I think it may be more useful once we have actual support for that in CuPy, RMM, etc.

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #488 (8ae2a16) into branch-0.18 (32d9d33) will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18     #488      +/-   ##
===============================================
+ Coverage        90.42%   91.14%   +0.72%     
===============================================
  Files               15       18       +3     
  Lines             1128     1446     +318     
===============================================
+ Hits              1020     1318     +298     
- Misses             108      128      +20     
Impacted Files Coverage Δ
dask_cuda/device_host_file.py 90.69% <0.00%> (-8.17%) ⬇️
dask_cuda/cuda_worker.py 76.66% <0.00%> (-0.35%) ⬇️
dask_cuda/cli/dask_cuda_worker.py 96.92% <0.00%> (ø)
dask_cuda/proxify_host_file.py 100.00% <0.00%> (ø)
dask_cuda/get_device_memory_objects.py 89.04% <0.00%> (ø)
dask_cuda/proxify_device_objects.py 85.71% <0.00%> (ø)
dask_cuda/local_cuda_cluster.py 81.17% <0.00%> (+0.68%) ⬆️
dask_cuda/proxy_object.py 90.62% <0.00%> (+2.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d9d33...8ae2a16. Read the comment docs.

@jakirkham jakirkham added 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team labels Jan 6, 2021
@rapids-bot rapids-bot bot merged commit 3e852b8 into rapidsai:branch-0.18 Jan 6, 2021
@pentschev pentschev deleted the extend-cupy-benchmark branch April 23, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants