Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --threads-per-worker option to benchmarks #489

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Add --threads-per-worker option to benchmarks #489

merged 2 commits into from
Jan 8, 2021

Conversation

pentschev
Copy link
Member

This is useful for PTDS benchmarking.

@pentschev pentschev added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 6, 2021
@pentschev pentschev requested a review from a team as a code owner January 6, 2021 21:20
@codecov-io
Copy link

codecov-io commented Jan 6, 2021 •
edited
Loading

Codecov Report

Merging #489 (12f32fd) into branch-0.18 (3e852b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.18     #489   +/-   ##
============================================
  Coverage        91.36%   91.36%           
============================================
  Files               18       18           
  Lines             1436     1436           
============================================
  Hits              1312     1312           
  Misses             124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e852b8...12f32fd. Read the comment docs.

@pentschev pentschev changed the title Add --thread-per-worker option to benchmarks Add --threads-per-worker option to benchmarks Jan 7, 2021
@jakirkham jakirkham added 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team labels Jan 8, 2021
@jakirkham
Copy link
Member

Thanks Peter! 😀

@rapids-bot rapids-bot bot merged commit cd8a87d into rapidsai:branch-0.18 Jan 8, 2021
@pentschev
Copy link
Member Author

Thanks @jakirkham !

@pentschev pentschev deleted the benchmarks-threads-per-worker branch June 29, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pentschev @codecov-io @jakirkham