Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxify register lazy #492

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Proxify register lazy #492

merged 2 commits into from
Jan 12, 2021

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jan 12, 2021

Fixes #491 by moving dispatch of cudf objects within a register_lazy("cudf").

@madsbk madsbk added bug Something isn't working 2 - In Progress Currently a work in progress non-breaking Non-breaking change labels Jan 12, 2021
@madsbk madsbk requested a review from pentschev January 12, 2021 09:05
@madsbk madsbk requested a review from a team as a code owner January 12, 2021 09:05
@codecov-io
Copy link

codecov-io commented Jan 12, 2021 •
edited
Loading

Codecov Report

Merging #492 (25b41a9) into branch-0.18 (32d9d33) will increase coverage by 1.42%.
The diff coverage is 94.60%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18     #492      +/-   ##
===============================================
+ Coverage        90.42%   91.85%   +1.42%     
===============================================
  Files               15       18       +3     
  Lines             1128     1485     +357     
===============================================
+ Hits              1020     1364     +344     
- Misses             108      121      +13
Impacted Files Coverage Δ
dask_cuda/cli/dask_cuda_worker.py 96.92% <ø> (ø)
dask_cuda/device_host_file.py 90.69% <66.66%> (-8.17%) ⬇️
dask_cuda/cuda_worker.py 78.75% <75.00%> (+1.73%) ⬆️
dask_cuda/get_device_memory_objects.py 89.04% <89.04%> (ø)
dask_cuda/proxify_device_objects.py 89.79% <89.79%> (ø)
dask_cuda/proxy_object.py 90.98% <95.14%> (+3.18%) ⬆️
dask_cuda/local_cuda_cluster.py 81.17% <100.00%> (+0.68%) ⬆️
dask_cuda/proxify_host_file.py 100.00% <100.00%> (ø)
dask_cuda/explicit_comms/utils.py 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8a87d...25b41a9. Read the comment docs.

@madsbk
Copy link
Member Author

madsbk commented Jan 12, 2021

rerun tests

1 similar comment
@pentschev
Copy link
Member

rerun tests

@madsbk madsbk added 3 - Ready for Review Ready for review by team 4 - Needs Reviewer Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress labels Jan 12, 2021
@pentschev
Copy link
Member

Heh, sorry I asked for a rerun at the same time as you @madsbk .

@madsbk
Copy link
Member Author

madsbk commented Jan 12, 2021

Heh, sorry I asked for a rerun at the same time as you @madsbk .

Hehe :)
gpuCI/dask-cuda/gpu/cuda/11.0/python/3.8/ubuntu18.04 still fails though

pentschev
pentschev approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @madsbk for this PR!

@pentschev
Copy link
Member

rerun tests

@pentschev
Copy link
Member

Heh, sorry I asked for a rerun at the same time as you @madsbk .

Hehe :)
gpuCI/dask-cuda/gpu/cuda/11.0/python/3.8/ubuntu18.04 still fails though

Yes, trying one last time, if that fails again I'll raise it with devops.

@pentschev
Copy link
Member

It failed again. @rapidsai/ops-codeowners could you please take a look in the gpuCI/dask-cuda/gpu/cuda/11.0/python/3.8/ubuntu18.04 build? It's failing right at the beginning during nvidia-smi -L.

@pentschev pentschev added 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Reviewer Waiting for reviewer to review or respond labels Jan 12, 2021
@madsbk
Copy link
Member Author

madsbk commented Jan 12, 2021

rerun tests

2 similar comments
@mike-wendt
Copy link
Contributor

rerun tests

@mike-wendt
Copy link
Contributor

rerun tests

@rapids-bot rapids-bot bot merged commit 7d27a0c into rapidsai:branch-0.18 Jan 12, 2021
@madsbk madsbk deleted the proxify_register_lazy branch February 5, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CUDA initialization error in proxify_device_objects.py
4 participants
@madsbk @codecov-io @pentschev @mike-wendt