Fix UCX examples for InfiniBand #556
Conversation
charlesbluca
added
python
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #556 +/- ##
================================================
+ Coverage 61.06% 92.46% +31.39%
================================================
Files 22 16 -6
Lines 2571 1605 -966
================================================
- Hits 1570 1484 -86
+ Misses 1001 121 -880
Continue to review full report at Codecov.
|
examples/ucx/client_initialize.py
Outdated
| x = rs.random((10000, 10000), chunks=1000) | ||
| x.sum().compute() | ||
|
|
||
| # shutdown client |
There was a problem hiding this comment.
| # shutdown client | |
| # shutdown cluster |
There was a problem hiding this comment.
This shuts down the entire cluster, not the client: https://distributed.dask.org/en/latest/api.html#distributed.Client.shutdown .
examples/ucx/client_initialize.py
Outdated
| client = Client(address) # noqa F841 | ||
| client = Client(address) | ||
|
|
||
| # client code here |
There was a problem hiding this comment.
This is a bit misleading, I would rename that to user code. Saying client code may sound like it's executed on the client-side only.
examples/ucx/local_cuda_cluster.py
Outdated
| x = rs.random((10000, 10000), chunks=1000) | ||
| x.sum().compute() | ||
|
|
||
| # shutdown client |
There was a problem hiding this comment.
| # shutdown client | |
| # shutdown cluster |
|
Thanks for the review @pentschev! |
pentschev
added
5 - Ready to Merge
|
@gpucibot merge |
Some small changes to the UCX examples to fix some IB-related issues I discussed with @pentschev:
--scheduler-fileto linkdask-schedulertodask-cuda-workers, aslocalhostcannot be used when IB is enabled