Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Deprecation/Future warnings as errors #672

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Treat Deprecation/Future warnings as errors #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b4c34d
Treat Deprecation/Future warnings as errors
pentschev Jul 13, 2021
47bec38
Fix np.bool warning
pentschev Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ci/gpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ else
gpuci_logger "Python pytest for dask-cuda"
cd "$WORKSPACE"
ls dask_cuda/tests/
UCXPY_IFNAME=eth0 UCX_WARN_UNUSED_ENV_VARS=n UCX_MEMTYPE_CACHE=n pytest -vs --cache-clear --basetemp="$WORKSPACE/dask-cuda-tmp" --junitxml="$WORKSPACE/junit-dask-cuda.xml" --cov-config=.coveragerc --cov=dask_cuda --cov-report=xml:"$WORKSPACE/dask-cuda-coverage.xml" --cov-report term dask_cuda/tests/
UCXPY_IFNAME=eth0 UCX_WARN_UNUSED_ENV_VARS=n UCX_MEMTYPE_CACHE=n pytest -vs -Werror::DeprecationWarning -Werror::FutureWarning --cache-clear --basetemp="$WORKSPACE/dask-cuda-tmp" --junitxml="$WORKSPACE/junit-dask-cuda.xml" --cov-config=.coveragerc --cov=dask_cuda --cov-report=xml:"$WORKSPACE/dask-cuda-coverage.xml" --cov-report term dask_cuda/tests/

gpuci_logger "Running dask.distributed GPU tests"
# Test downstream packages, which requires Python v3.7
Expand All @@ -117,12 +117,12 @@ else
git clone https://github.com/dask/distributed

gpuci_logger "Run Distributed Tests"
pytest --cache-clear -vs distributed/distributed/protocol/tests/test_cupy.py
pytest --cache-clear -vs distributed/distributed/protocol/tests/test_numba.py
pytest --cache-clear -vs distributed/distributed/protocol/tests/test_rmm.py
pytest --cache-clear -vs distributed/distributed/protocol/tests/test_collection_cuda.py
pytest --cache-clear -vs distributed/distributed/tests/test_nanny.py
pytest --cache-clear -vs distributed/distributed/diagnostics/tests/test_nvml.py
pytest --cache-clear -vs -Werror::DeprecationWarning -Werror::FutureWarning distributed/distributed/protocol/tests/test_cupy.py
pytest --cache-clear -vs -Werror::DeprecationWarning -Werror::FutureWarning distributed/distributed/protocol/tests/test_numba.py
pytest --cache-clear -vs -Werror::DeprecationWarning -Werror::FutureWarning distributed/distributed/protocol/tests/test_rmm.py
pytest --cache-clear -vs -Werror::DeprecationWarning -Werror::FutureWarning distributed/distributed/protocol/tests/test_collection_cuda.py
pytest --cache-clear -vs -Werror::DeprecationWarning -Werror::FutureWarning distributed/distributed/tests/test_nanny.py
pytest --cache-clear -vs -Werror::DeprecationWarning -Werror::FutureWarning distributed/distributed/diagnostics/tests/test_nvml.py
fi

logger "Run local benchmark..."
Expand Down
2 changes: 1 addition & 1 deletion dask_cuda/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def unpack_bitmask(x, mask_bits=64):
bytestr = np.frombuffer(
bytes(np.binary_repr(mask, width=mask_bits), "utf-8"), "u1"
)
mask = np.flip(bytestr - ord("0")).astype(np.bool)
mask = np.flip(bytestr - ord("0")).astype(bool)
unpacked_mask = np.where(
mask, np.arange(mask_bits) + cpu_offset, np.full(mask_bits, -1)
)
Expand Down