Add device memory limit argument to benchmarks #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
added
python
|
rerun tests |
pentschev
requested changes
Jul 23, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #683 +/- ##
================================================
+ Coverage 87.83% 90.30% +2.47%
================================================
Files 15 15
Lines 1652 1651 -1
================================================
+ Hits 1451 1491 +40
+ Misses 201 160 -41
Continue to review full report at Codecov.
|
pentschev
requested changes
Jul 23, 2021
dask_cuda/benchmarks/utils.py
Outdated
| @@ -202,6 +212,8 @@ def get_cluster_options(args): | |||
| worker_options["enable_infiniband"] = "" | |||
| if args.enable_rdmacm: | |||
| worker_options["enable_rdmacm"] = "" | |||
| if args.device_memory_limit: | |||
| worker_options["device_memory_limit"] = "" | |||
There was a problem hiding this comment.
Now it's missing the value to be assigned, which I believe should be args.device_memory_limit.
pentschev
approved these changes
Jul 23, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--device-memory-limitargument to the benchmark utils, to set a device memory limit on the instantiatedLocalCUDACluster. This can be helpful when we want to force spilling to host (for context, I am doing this while benchmarking pack/unpack serialization).