Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aliases to check for installed UCX version #692

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Use aliases to check for installed UCX version #692

merged 1 commit into from
Jul 28, 2021

Conversation

pentschev
Copy link
Member

Fixes #691

@pentschev pentschev requested a review from a team as a code owner July 28, 2021 15:22
@github-actions github-actions bot added the python python code needed label Jul 28, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Jul 28, 2021
quasiben
quasiben approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pentschev !

@quasiben
Copy link
Member

@gpucibot merge

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@a0217f4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 14827ef differs from pull request most recent head f1bc6fe. Consider uploading reports for the commit f1bc6fe to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08     #692   +/-   ##
===============================================
  Coverage                ?   90.10%           
===============================================
  Files                   ?       15           
  Lines                   ?     1658           
  Branches                ?        0           
===============================================
  Hits                    ?     1494           
  Misses                  ?      164           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0217f4...f1bc6fe. Read the comment docs.

@rapids-bot rapids-bot bot merged commit c9e3907 into rapidsai:branch-21.08 Jul 28, 2021
@pentschev pentschev deleted the ucx-version-alias branch August 12, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

@charlesbluca charlesbluca charlesbluca approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure if UCP is not installed
4 participants
@pentschev @quasiben @codecov-commenter @charlesbluca