Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Pin max dask & distributed versions #794

Merged
merged 2 commits into from
Nov 22, 2021
Merged

[REVIEW] Pin max dask & distributed versions #794

merged 2 commits into from
Nov 22, 2021

Conversation

galipremsagar
Copy link
Contributor

Changes to be in-line with rapidsai/cudf#9734

@galipremsagar galipremsagar requested a review from a team as a code owner November 19, 2021 16:30
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Nov 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@7f00ee2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 36e8597 differs from pull request most recent head b0f39d8. Consider uploading reports for the commit b0f39d8 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #794   +/-   ##
===============================================
  Coverage                ?   90.11%           
===============================================
  Files                   ?       15           
  Lines                   ?     1992           
  Branches                ?        0           
===============================================
  Hits                    ?     1795           
  Misses                  ?      197           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f00ee2...b0f39d8. Read the comment docs.

@ajschmidt8
Copy link
Member

awaiting a reply to Peter's inquiry before approving this one

@pentschev pentschev added 2 - In Progress Currently a work in progress feature request New feature or request non-breaking Non-breaking change labels Nov 19, 2021
jakirkham
jakirkham reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion offline suggesting we constrain dask & distributed with >=2021.11.1,<=2021.11.2

@galipremsagar @jakirkham
Apply suggestions from code review
b0f39d8 
Co-authored-by: jakirkham <jakirkham@gmail.com>
pentschev
pentschev approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar !

@pentschev
Copy link
Member

Could you approve this @ajschmidt8 ?

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a9d2554 into branch-21.12 Nov 22, 2021
@jakirkham jakirkham deleted the dask_pin_new branch November 22, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@pentschev pentschev pentschev approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
2 - In Progress Currently a work in progress conda conda issue feature request New feature or request gpuCI gpuCI issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @codecov-commenter @ajschmidt8 @pentschev @jakirkham