Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Distributed config separator in get_ucx_config #806

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Standardize Distributed config separator in get_ucx_config #806

merged 4 commits into from
Nov 23, 2021

Conversation

pentschev
Copy link
Member

Some of the UCX configurations used _ whereas others used - as a separator. This has been standardized in dask/distributed#5539, and this updates Dask-CUDA to the new standard.

@pentschev pentschev requested a review from a team as a code owner November 22, 2021 16:00
@github-actions github-actions bot added the python python code needed label Nov 22, 2021
@pentschev pentschev added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed python python code needed labels Nov 22, 2021
@pentschev pentschev changed the base branch from branch-21.12 to branch-22.02 November 22, 2021 17:52
@github-actions github-actions bot added the python python code needed label Nov 22, 2021
@pentschev
Copy link
Member Author

rerun tests

madsbk
madsbk approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pentschev, thanks.

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c8618fd into rapidsai:branch-22.02 Nov 23, 2021
@pentschev
Copy link
Member Author

Thanks @madsbk !

@pentschev pentschev deleted the standardize-distributed-ucx-config-separator branch November 23, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pentschev @madsbk