Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex pattern to match to in test_on_demand_debug_info #819

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix regex pattern to match to in test_on_demand_debug_info #819

merged 1 commit into from
Dec 8, 2021

Conversation

pentschev
Copy link
Member

The string for bad allocation from RMM has changed from to include the type of error, now std::bad_alloc: out_of_memory: CUDA error a, previously std::bad_alloc: CUDA error at, the regex change included here matches both cases now.

@pentschev pentschev requested a review from a team as a code owner December 8, 2021 17:04
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Dec 8, 2021
@github-actions github-actions bot added the python python code needed label Dec 8, 2021
@pentschev
Copy link
Member Author

Btw, this is currently blocking CI: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/dask-cuda/job/prb/job/dask-cuda-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.7/645/testReport/junit/dask_cuda.tests/test_proxify_host_file/test_on_demand_debug_info/

madsbk
madsbk approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pentschev, thanks!

@madsbk
Copy link
Member

madsbk commented Dec 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 55edb30 into rapidsai:branch-22.02 Dec 8, 2021
@pentschev
Copy link
Member Author

Thanks for reviewing/merging @madsbk !

@pentschev pentschev deleted the fix-test_on_demand_debug_info branch January 14, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pentschev @madsbk