Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NVIDIA AI Workbench documentation #497

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Add NVIDIA AI Workbench documentation #497

merged 5 commits into from
Jan 27, 2025

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jan 23, 2025 •
edited
Loading

Add documentation for NVIDIA AI Workbench.

Closes #433
Closes #394
Closes #320

@jacobtomlinson jacobtomlinson requested a review from a team as a code owner January 23, 2025 14:02
@jacobtomlinson jacobtomlinson added doc Improvements or additions to documentation platform/nvidia/aiwkb NVIDIA AI Workbench labels Jan 23, 2025
ncclementi
ncclementi approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for putting this together.
LGTM! I left some suggestions and comments but nothing blocking.

source/platforms/nvidia-ai-workbench.md Outdated Show resolved Hide resolved
source/platforms/nvidia-ai-workbench.md Outdated Show resolved Hide resolved
source/platforms/nvidia-ai-workbench.md Outdated Show resolved Hide resolved
source/platforms/nvidia-ai-workbench.md Outdated Show resolved Hide resolved
source/platforms/nvidia-ai-workbench.md Outdated Show resolved Hide resolved
source/platforms/nvidia-ai-workbench.md Outdated Show resolved Hide resolved
source/platforms/nvidia-ai-workbench.md Outdated Show resolved Hide resolved
jacobtomlinson and others added 2 commits January 24, 2025 11:17
@jacobtomlinson
Copy link
Member Author

Thanks for the feedback, I've applied the suggestions and tweaked wording a bit. Ready for review again.

ncclementi
ncclementi approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jacobtomlinson jacobtomlinson merged commit 8615200 into rapidsai:main Jan 27, 2025
3 checks passed
@jacobtomlinson jacobtomlinson deleted the aiwkb branch January 27, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncclementi ncclementi ncclementi approved these changes

Assignees
No one assigned
Labels
doc Improvements or additions to documentation platform/nvidia/aiwkb NVIDIA AI Workbench
Projects
None yet
Milestone
No milestone
2 participants
@jacobtomlinson @ncclementi