Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rapids-configure-conda-channels idempotent #104

Merged
merged 6 commits into from
May 14, 2024
+22 −3
Merged

make rapids-configure-conda-channels idempotent #104

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ec4627
make rapids-configure-conda-channels idempotent
jameslamb Apr 25, 2024
e278f17
Update tools/rapids-configure-conda-channels
jameslamb Apr 30, 2024
f1464ce
refactor, add -eou pipefail
jameslamb May 13, 2024
c4cf5bb
Merge branch 'main' into idempotent-configure-conda-channels
jameslamb May 13, 2024
41566d5
Merge branch 'idempotent-configure-conda-channels' of github.com:jame…
jameslamb May 13, 2024
c57bebf
remove unused variable
jameslamb May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions tools/rapids-configure-conda-channels
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,29 @@
#!/bin/bash
# A utility script that configures conda channels

conda_channel_in_config() {
channel_id=${1:?err}
conda config --json --get channels \
| jq -r --arg c "${channel_id}" '."get"."channels" | any(. == $c )'
ajschmidt8 marked this conversation as resolved.
Show resolved Hide resolved
}

# Only try to run 'conda config --remove' if the channel exists in the config.
# This is here to avoid errors if this script is invoked multiple times in the same
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
remove_conda_channel() {
channel_id=${1:?err}
in_config=$(conda_channel_in_config "${channel_id}")
if [[ "${in_config}" == "true" ]]; then
conda config --system --remove channels "${channel_id}"
else
echo "[rapids-configure-conda-channels] channel '${channel_id}' not found via 'conda config --get channels'"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing adding this so we have a chance of catching the "there was a typo in the channel name" case.

In theory this should never show up in CI logs unless there's a problem, since this script should only be run once during CI jobs.

fi
}

# Remove nightly channels if build is a release build
if rapids-is-release-build; then
conda config --system --remove channels rapidsai-nightly
conda config --system --remove channels dask/label/dev
remove_conda_channel 'rapidsai-nightly'
remove_conda_channel 'dask/label/dev'
else
# exclude stable channel from all non-release builds.
conda config --system --remove channels rapidsai
remove_conda_channel 'rapidsai'
fi