Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rapids-otel-wrap for simplicity #139

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

msarahan
Copy link
Contributor

@msarahan msarahan commented Feb 4, 2025

This proved fragile, and the complexity of having this here is not worth the potential future application. It was fragile in the sense that instrumenting conda-build led to bizarre failures that would be deep rabbit holes to investigate.

@msarahan msarahan requested a review from a team as a code owner February 4, 2025 16:14
@msarahan msarahan requested review from gforsyth and removed request for a team February 4, 2025 16:14
This proved fragile, and the complexity of having this here
is not worth the potential future application. It was fragile
in the sense that instrumenting conda-build led to bizarre
failures that would be deep rabbit holes to investigate.
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for coming back to rip this out!

@msarahan msarahan merged commit 30a8ac5 into rapidsai:main Feb 4, 2025
1 check passed
@msarahan msarahan deleted the remove-otel-wrap branch February 4, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants