Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to test nightly environments are solvable and using recent nightlies. #690
Add script to test nightly environments are solvable and using recent nightlies. #690
Changes from all commits
40ded38
551169f
d78a83f
df6074e
98383f6
d487411
55da82b
9d3a8b0
b323bfa
c245fc6
4af2f57
0f4741f
d9478b4
df76342
26e4143
52c5308
171644a
a27c3fc
2a5c29c
4aeb2f5
15c2c9d
9b72086
925dd58
ede8cf2
f76b29a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(was going to put this as my review, realized a thread would probably be better)
I totally support adding something like this, based on your description offline:
But I don't think it offers 100% protection against the case described in https://github.com/rapidsai/ops/issues/2947.
That issue is not about just packages building against too-old versions of dependencies... it's about packages across RAPIDS building against very different versions of dependencies.
It looks to me that the code in this PR would catch cases like these:
rmm
nightlies haven't been published in the last 3 days"cugraph
andpylibraft
can't be installed in the same environment"These aren't captured by the existing nightly tests at https://github.com/rapidsai/workflows/actions/workflows/nightly-pipeline.yaml.
But this wouldn't be guaranteed to catch a case like this:
cuml
nightly built against anrmm
from 5 days ago, but the latestcudf
nightly built against anrmm
from yesterday"Because this test with the
rapids
package is solving across all of the packages' runtime dependencies, but they could have ended up building against older versions based on conflicts in their individual build environments, right?And those types of conflicts might not show up here if we use
pin_compatible(max_pin="x.x")
inrun
dependencies, e.g.pylibraft==24.10.*
is going to have a runtime dependency onrmm=24.10.*
regardless of which specific nightly ofrmm
it pulled in at build time. (pylibraft nightly files)I think detecting that other case would have to happen at build time (or by post-processing of logs from build time). And I don't know how complex that would be, so can't say with confidence that the complexity would be worth it.
I totally support the approach this PR is pursuing, just wanted to be sure to note this other possible avenue for version mismatches to get through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct about what this will and will not cover. I think it's worth pursuing because (1) it prevents runtime problems from being hidden and (2) sometimes runtime conflicts will also affect build environments, so this may give us a bit of signal into deeper problems happening at build time, should they arise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great! I totally support moving forward with this.