[REVIEW] Defer loading of custom.js
#114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
doc
ajschmidt8
approved these changes
Aug 4, 2022
|
@gpucibot merge |
vuule
pushed a commit
to vuule/kvikio
that referenced
this pull request
Nov 8, 2023
As described in https://github.com/rapidsai/cudf-private/pull/26#issuecomment-1777374538, our proxying of `pd.Timestamp` leads us down an erroneous codepath in CPython eventually terminating in a segfault. Until this is possibly fixed in CPython, this PR unproxies `Timestamp`, so that `pd.Timestamp` returns a "real" Pandas timestamp object. There's no equivalent "cudf.Timestamp", so we don't particularly lose out on any performance. One _potential_ concern with this approach is that operations between `pd.Timestamp` and proxy objects can yield "true" Pandas objects instead of proxy objects. I haven't seen that happen for things like `+` and comparisons (`>`), but it's worth keeping in mind that it's a _possibility_. Authors: - Ashwin Srinath (https://github.com/shwina) - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Matthew Roeschke (https://github.com/mroeschke) URL: https://github.com/rapidsai/cudf-private/pull/114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the loading of
custom.jstodeferbecause we will need the entire page to be loading until the methods in this script can even execute correctly.xref: rapidsai/cudf#11465