Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand cuda/RMM tests and docs #118

Merged
merged 10 commits into from
Mar 15, 2021
Merged

Expand cuda/RMM tests and docs #118

merged 10 commits into from
Mar 15, 2021

Conversation

trxcllnt
Copy link
Collaborator

  • Expands and cleans up docs in the CUDA and RMM modules
  • Adds more tests and functionality to the MemoryView classes

Branched from #117

@trxcllnt trxcllnt added documentation Improvements or additions to documentation enhancement New feature or request module: CUDA module: RMM module: demos labels Mar 15, 2021
@trxcllnt trxcllnt mentioned this pull request Mar 15, 2021
Closed
@trxcllnt trxcllnt requested a review from bryevdv March 15, 2021 15:32
bryevdv
bryevdv reviewed Mar 15, 2021
View reviewed changes
modules/cuda/src/util.ts Outdated Show resolved Hide resolved
@bryevdv
Copy link
Contributor

bryevdv commented Mar 15, 2021

LGTM just the one doc comment

@trxcllnt trxcllnt merged commit e55c2f9 into rapidsai:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryevdv bryevdv bryevdv approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request module: CUDA module: demos module: RMM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trxcllnt @bryevdv