-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Upgrade to spdlog 1.10 (#1173)" #1176
Conversation
This reverts commit 7bf7a76.
@gpucibot merge |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1176 +/- ##
==============================================
Coverage ? 0.00%
==============================================
Files ? 5
Lines ? 406
Branches ? 0
==============================================
Hits ? 0
Misses ? 406
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
This reverts commit 4b079dc. See rapidsai/rmm#1176 for details. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - Vyas Ramasubramani (https://github.com/vyasr) URL: #323
You linked to librmm's meta.yaml here, was that intentional? I believe the original thinking was that librmm is header only so we didn't actually need spdlog as a
The pinning has since been updated to 1.11.0 (https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/conda_build_config.yaml#L680-L681) so we should be able to skip 1.10.0 and go straight to 1.11.0. As of now, the 1.11.0 package in conda-forge uses external fmt, but as you said discussion is ongoing and I'm somewhat unclear on all of the implications of the different options. That being said, it should be straightforward enough to match the conda-forge package behavior in rapids-cmake by handling It looks like RMM C++ code uses |
Description
This reverts commit 7bf7a76.
cc: @kkraus14 There's a handful of issues this caused downstream. We'll be sorting through these and fixing them but need to quickly revert this for now.
Currrent problems:
-- CPM: adding package spdlog@1.8.5 (v1.8.5)
and then clobbers its own installed spdlog headers:fmt=9.1.0
in the conda package cases? @kkraus14 It looks like you weighed in on this matter here and here. If you have insights that can help us with this quandary, please share!Checklist