Add functionality for user to register close callback #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user callback is registered, the Endpoint error callback or its finalizer will run the callback to inform the user's application that the Endpoint is terminating and will not accept sending new messages, although receiving may still be possible as UCP may still have some incoming messages in transit.
Since ep.close() calls worker.progress() it can't be called within the listener callback, therefore we have to progress outside until the callback is called. We must check the processes' exitcodes to be `0`, if they timeout the exitcode is `None`, which can't be checked correctly just with `not process.exitcode`.
madsbk
requested changes
Oct 28, 2021
There was a problem hiding this comment.
Nice feature @pentschev, I only have some minor suggestions
|
Thanks @madsbk for the review, I think I addressed everything. Could you take another look when you have the chance? |
madsbk
approved these changes
Oct 28, 2021
|
Thanks @madsbk ! |
This was referenced Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a similar feature to
tornado.BaseIOStream.set_close_callbackand allows the application to immediately find out when the remote endpoint has closed or failed. This can be useful in places such as Distributed, where we want to still be able to read messages that are already in-transit, but the endpoint isn't anymore valid for sending messages.