Fix pip dependencies #169
Merged
Fix pip dependencies #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
improvement
bdice
reviewed
Jan 18, 2024
| @@ -41,7 +41,7 @@ classifiers = [ | |||
| test = [ | |||
| "cloudpickle", | |||
| "cudf==24.2.*", | |||
| "cupy", | |||
| "cupy-cuda11x>=12.0.0", | |||
There was a problem hiding this comment.
We're inconsistent in how we handle cudf/cupy fallback. This is a problem across basically all of RAPIDS, so it'd be good for us to unify our approaches.
If we need cupy-cuda11x here, we would probably want cudf-cu11 as well. For all RAPIDS packages we've been falling back to the "conda name" but we've been falling back to the "CUDA 11 pip name" for cupy. We should do one of:
- use
cudfandcupy - use
cudf-cu11andcupy-cuda11x
There was a problem hiding this comment.
I'm using the "conda name" here because it works automatically when building the repos from source.
There was a problem hiding this comment.
Gotcha. I wondered about that. We can leave this as-is, then.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
approved these changes
Jan 18, 2024
pentschev
approved these changes
Jan 18, 2024
|
/merge |
raydouglass
approved these changes
Jan 18, 2024
jameslamb
pushed a commit
to jameslamb/ucxx
that referenced
this pull request
Jan 22, 2024
* Move conda-only dependencies out of `pyproject` and `requirements` sections in `dependencies.yaml` * Add `rmm`, `cudf`, and `cupy` matrices Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Bradley Dice (https://github.com/bdice) - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyprojectandrequirementssections independencies.yamlrmm,cudf, andcupymatrices