This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Use default rapids-cmake CUDA_ARCHITECTURES
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
improvement
bdice
approved these changes
Mar 4, 2024
|
/merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake initializes
CMAKE_CUDA_ARCHITECTURESfrom theCUDAARCHSenvironment variable.Defaulting
CMAKE_CUDA_ARCHITECTURESto a fixed list of archs prevents CMake from initializing the value from the envvar.This PR skips setting
CMAKE_CUDA_ARCHITECTURES, and instead usesrapids-cmakedefault behavior of initializing from theCUDAARCHSenvvar and falling back to the same default archs list as is currently used inbuild.sh.