Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Grace Hopper support and add benchmark #87

Merged
merged 13 commits into from
Nov 17, 2023
Merged

Grace Hopper support and add benchmark #87

merged 13 commits into from
Nov 17, 2023

Conversation

dongxuy04
Copy link
Contributor

Changes of this PR:

  • Merged benchmark code from @hello-11
  • Merged some MNNVL code from @hello-11
  • Added some system info detection
  • Skipped some test cases on not support platforms
  • Added support for multinode benchmark
  • Get functional worked on MNNVL GraceHopper systems.
  • Update communicator stream to be nonblocking.

@dongxuy04 dongxuy04 added feature request New feature or request non-breaking Introduces a non-breaking change labels Nov 1, 2023
@dongxuy04 dongxuy04 marked this pull request as ready for review November 2, 2023 11:57
BradReesWork
BradReesWork suggested changes Nov 15, 2023
View reviewed changes
cpp/bench/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/bench/common/wholegraph_benchmark.hpp Outdated Show resolved Hide resolved
cpp/src/net_utils.cpp Show resolved Hide resolved
cpp/bench/wholememory_ops/gather_scatter_bench.cu Outdated Show resolved Hide resolved
cpp/src/net_utils.h Show resolved Hide resolved
cpp/src/wholememory/system_info.cpp Show resolved Hide resolved
cpp/src/wholememory/system_info.hpp Show resolved Hide resolved
dongxuy04 and others added 7 commits November 16, 2023 09:35
@dongxuy04 @BradReesWork
Update cpp/bench/CMakeLists.txt
dab2cfb 
Co-authored-by: Brad Rees <34135411+BradReesWork@users.noreply.github.com>
@dongxuy04 @BradReesWork
Update cpp/bench/common/wholegraph_benchmark.hpp
69a4938 
Co-authored-by: Brad Rees <34135411+BradReesWork@users.noreply.github.com>
@dongxuy04 @BradReesWork
Update cpp/src/net_utils.cpp
e5f8cf3 
Co-authored-by: Brad Rees <34135411+BradReesWork@users.noreply.github.com>
@dongxuy04 @BradReesWork
Update cpp/bench/wholememory_ops/gather_scatter_bench.cu
2614787 
Co-authored-by: Brad Rees <34135411+BradReesWork@users.noreply.github.com>
@dongxuy04 @BradReesWork
Update cpp/src/net_utils.h
1c4642f 
Co-authored-by: Brad Rees <34135411+BradReesWork@users.noreply.github.com>
@dongxuy04 @BradReesWork
Update cpp/src/wholememory/system_info.cpp
9f96fad 
Co-authored-by: Brad Rees <34135411+BradReesWork@users.noreply.github.com>
@dongxuy04 @BradReesWork
Update cpp/src/wholememory/system_info.hpp
46a3764 
Co-authored-by: Brad Rees <34135411+BradReesWork@users.noreply.github.com>
@BradReesWork BradReesWork added this to the 23.12 milestone Nov 17, 2023
@BradReesWork BradReesWork mentioned this pull request Nov 17, 2023
Closed
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 7f21e39 into rapidsai:branch-23.12 Nov 17, 2023
43 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hello-11 hello-11 hello-11 approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
23.12
Development

Successfully merging this pull request may close these issues.
3 participants
@dongxuy04 @BradReesWork @hello-11