Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI Workflow faster #140

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Make CI Workflow faster #140

merged 1 commit into from
Mar 15, 2022

Conversation

TaKO8Ki
Copy link
Contributor

@TaKO8Ki TaKO8Ki commented Mar 15, 2022 •
edited
Loading

This pull request disables incremental compilation in CI.

CI builds often are closer to from-scratch builds, as changes are typically much bigger than from a local edit-compile cycle. For from-scratch builds, incremental adds an extra dependency-tracking overhead. It also significantly increases the amount of IO and the size of ./target, which make caching less effective.

ref: https://matklad.github.io/2021/09/04/fast-rust-builds.html

@TaKO8Ki TaKO8Ki changed the title Make Ci Workflow faster Make CI Workflow faster Mar 15, 2022
@rapiz1 rapiz1 enabled auto-merge (squash) March 15, 2022 13:51
@rapiz1 rapiz1 merged commit f9ee8ec into rapiz1:main Mar 15, 2022
@TaKO8Ki TaKO8Ki deleted the make-ci-workflow-faster branch March 15, 2022 13:53
TaKO8Ki added a commit to TaKO8Ki/rathole that referenced this pull request Mar 23, 2022
@TaKO8Ki
Revert "ci: disable incremental compilation (rapiz1#140)"
3f5a9b3 
This reverts commit f9ee8ec.
@TaKO8Ki TaKO8Ki mentioned this pull request Mar 23, 2022
Merged
rapiz1 pushed a commit that referenced this pull request Mar 25, 2022
@TaKO8Ki
revert(ci): disable incremental compilation (#140) (#144)
636bdbd 
This reverts commit f9ee8ec.
cssivision pushed a commit to cssivision/rathole that referenced this pull request Apr 21, 2022
@TaKO8Ki
ci: disable incremental compilation (rapiz1#140)
baea325
cssivision pushed a commit to cssivision/rathole that referenced this pull request Apr 21, 2022
@TaKO8Ki
revert(ci): disable incremental compilation (rapiz1#140) (rapiz1#144)
a40dc16 
This reverts commit f9ee8ec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaKO8Ki @rapiz1