fix: enable TCP_NODELAY by default #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have reported use cases like MC servers, rdp #171 #209 for rathole. These interactive applications greatly benefit from the TCP_NODELAY flag, which is by default off. Considering large files transferring and web disk application usage for rathole is relatively rare. And even with TCP_NODELAY, rathole provides good bandwidth utilization. It will be reasonable to enable TCP_NODELAY by default.
Users who host web disk applications can still opt out TCP_NODELAY by configuration.