Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bootstrap 5 themed checkboxes and selects #868

Closed
gjm opened this issue Aug 8, 2022 · 7 comments
Closed

Use Bootstrap 5 themed checkboxes and selects #868

gjm opened this issue Aug 8, 2022 · 7 comments

Comments

@gjm
Copy link

gjm commented Aug 8, 2022

In the column visibility and results per page selector, the controls are not using the themed inputs in bootstrap-5 theme.

For checkboxes form-check class must be added to the wrapper div and form-check-input class to the input tag and for selects form-select class must be added to the select tag.

@WhereIsLucas
Copy link
Contributor

My PR #864 fixes the select input problem, and I will add the checkbox styling too.

@WhereIsLucas
Copy link
Contributor

This is fixed in the PR, we should wait for someone to merge it, thanks for pointing it out !

@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 8, 2022
@stale stale bot closed this as completed Sep 16, 2022
@rappasoft rappasoft reopened this Sep 16, 2022
@stale stale bot closed this as completed Sep 23, 2022
@rappasoft rappasoft reopened this Sep 24, 2022
@stale stale bot removed the wontfix This will not be worked on label Sep 24, 2022
@stale
Copy link

stale bot commented Oct 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 25, 2022
@stale stale bot closed this as completed Nov 1, 2022
@rappasoft rappasoft reopened this Nov 1, 2022
@stale stale bot closed this as completed Nov 9, 2022
@rappasoft rappasoft reopened this Nov 10, 2022
@stale stale bot removed the wontfix This will not be worked on label Nov 10, 2022
@WhereIsLucas
Copy link
Contributor

Hi @rappasoft,

Would it be possible to merge the linked PR #864 ?

Does it need more work ?

Thanks !

@stale
Copy link

stale bot commented Dec 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 10, 2022
@stale stale bot closed this as completed Dec 17, 2022
@rappasoft rappasoft reopened this Dec 19, 2022
@stale stale bot removed the wontfix This will not be worked on label Dec 19, 2022
@rappasoft
Copy link
Owner

Included in the next release. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants