-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for select and checkbox inputs styling with Bootstrap 5 theme #864
Conversation
As issue #868 pointed, checkbox inputs were also incorrectly styled for Bootstrap 5. I added the fixes to my current PR for select. |
Hi, Any chance this PR gets merged ? Thanks ! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Can this be merged or does it need more work? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Thanks ! |
I think the bulk actions is not fixed. Let me see if I can just grab the code for that control. |
I don't remember what I did, but I changed something in this section toolbar.blade.php:490 or around.
|
This allows for the bulk options to dropdown, it looks good, but does not work. |
This was a change implemented via the coreui update.
Reference to rappasoft#864 fixes for bootstrap-5 theme
* Reference to rappasoft#864 fixes for bootstrap-5 theme This was a change implemented via the coreui update. * Updated toolbar.php to allow dropdown functionality. Changed the dropdown behavior to Alpine.js to the same behavior as the column select. * Update toolbar.blade.php wire:key name was incorrect. --------- Co-authored-by: ccsliinc <jsugamele@gmail.com>
All Submissions:
Hi,
The arrow on the select input is not visible with the Bootstrap 5 theme.
![image](https://user-images.githubusercontent.com/25830895/183398425-805c88f5-773a-4f3c-ad5c-7e69559c9d05.png)
![image](https://user-images.githubusercontent.com/25830895/183398470-451c8fcb-9ddc-4961-bd19-9672d2c4ae44.png)
This is due to the fact that Bootstrap 5 selects are now using the form-select class instead of form-control.
See below in the docs :
https://getbootstrap.com/docs/5.2/forms/select/
https://getbootstrap.com/docs/5.0/migration/
This PR fixes this.