Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ViewComponentColumn #1818

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Aug 4, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (40485a0) to head (2f8e51d).
Report is 26 commits behind head on development.

Files Patch % Lines
src/Views/Columns/ViewComponentColumn.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1818      +/-   ##
=================================================
+ Coverage          87.14%   88.23%   +1.09%     
- Complexity          1495     1564      +69     
=================================================
  Files                139      144       +5     
  Lines               3484     3646     +162     
=================================================
+ Hits                3036     3217     +181     
+ Misses               448      429      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit e2308a0 into rappasoft:development Aug 4, 2024
8 of 9 checks passed
@lrljoe lrljoe mentioned this pull request Aug 4, 2024
9 tasks
lrljoe added a commit that referenced this pull request Aug 4, 2024
## [v3.4.1] - 2024-08-04
### Bug Fixes
- Fix ViewComponentColumn issue with not accepting parameters cleanly by @lrljoe in #1818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant