Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select all delay on "select all" checkbox #2122

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

matberry
Copy link

This fixes #1996

Select all checkbox now works as intended when using setDelaySelectAllEnabled()

Open to criticism since it's my first PR here !

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe
Copy link
Collaborator

lrljoe commented Dec 10, 2024

Looks sensible at face value, will need to do some validation before I fire the tests and merge it in though!

@lrljoe
Copy link
Collaborator

lrljoe commented Dec 26, 2024

I've been making some other adjustments to the JS, but am aware/conscious of this PR, so I'll look to incorporate it once I've finished the other adjustments.
Should be at the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants