Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default Filter Input Styling #2132

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 24, 2024

This PR begins to migrate the default styling for Filters into a centralised method, which in future will allow for standardising filter input classes across a table.

This is not implemented in the views as of yet, as there are some considerations for Tailwind class inclusion.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.68%. Comparing base (4bb6b3d) to head (5f78054).

Files with missing lines Patch % Lines
.../Styling/Defaults/HasDefaultFilterInputStyling.php 90.90% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             development    #2132   +/-   ##
==============================================
  Coverage          90.67%   90.68%           
- Complexity          1966     1976   +10     
==============================================
  Files                203      204    +1     
  Lines               4463     4485   +22     
==============================================
+ Hits                4047     4067   +20     
- Misses               416      418    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe marked this pull request as draft December 26, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant