Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix results count on tailwind theme #239

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

bdelamatre
Copy link
Contributor

Ensures that a results count is displayed even when a) there is less than one page of results and b) pagination is disabled

@rappasoft
Copy link
Owner

Hmm we should probably do this for all of the themes.

@bdelamatre
Copy link
Contributor Author

A quick smoke test and looked like this was already working somehow for bootstrap and the current pagination views. Not sure why the difference.

@rappasoft
Copy link
Owner

Hmm for me pagination does not show lol. I'll dig into it.

@rappasoft
Copy link
Owner

rappasoft commented Apr 27, 2021

Bootstrap 4 and 5 show nothing for me if paginationEnabled is false, also just noticed, tailwind pagination has the results and links reversed from what Bootstrap has - I'll update the templates.

@rappasoft rappasoft merged commit 8dc9eb0 into rappasoft:develop Apr 27, 2021
@developman-akl
Copy link

@rappasoft Is it possible to only show either the pager buttons OR the "Showing .." text with the pagination buttons on the right? Having them all at once with Tailwind is a little bit too much:
image

@rappasoft
Copy link
Owner

It's normally just the right side of your screenshot. I don't know how you got both simple and advanced pagination to show up at once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants