add-missing-translation-labels #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The translations are redundant but I plucked the search type. |
rappasoft
added
the
Awaiting Next Release
|
but how to translate keywords in pagination statistics? |
|
In the current version it's still a translation string you just need to use the json format. In the next version it's |
lrljoe
added a commit
that referenced
this pull request
Mar 30, 2023
* Restrict AppliedFilters to only return non-empty At the moment, a filter will be considered "applied" if it has any value, including the default value. This causes the Pills to appear with a blank value. * Moving to withValues to make more sense * Initial Commit * Add variable to Filter.php * Filter LabelID (#32) * Amended to removing formatting adjustments Adding ID to Label Update toolbar.blade.php Adding new line at EOF * Update toolbar.blade.php Adding ID to Wrapper * Amended to removing formatting adjustments Adding ID to Label Adding ID to Wrapper Adding new line at EOF Update toolbar.blade.php Adding ID to Wrapper * Update toolbar.blade.php Adds IDs to Filter Labels Adds IDs to Filter Wrappers Restores removed EOF newline * Restoring New Line at EOF * Child open attribute (#35) * Adding childElementOpen attr for all toolbar items. * Adjusting Toolbar to remove errant formatting * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Set filter pill custom blade (#33) * Initial Commit * Add variable to Filter.php * Get applied filters only non empty (#34) * Restrict AppliedFilters to only return non-empty At the moment, a filter will be considered "applied" if it has any value, including the default value. This causes the Pills to appear with a blank value. * Moving to withValues to make more sense * Set filter row colspan (#36) * Adding Custom Slug option (#21) Adding new methods & test Adding documentation * Filter label (#22) * Amended to removing formatting adjustments Adding ID to Label Update toolbar.blade.php Adding new line at EOF * Update toolbar.blade.php Adding ID to Wrapper * Amended to removing formatting adjustments Adding ID to Label Adding ID to Wrapper Adding new line at EOF Update toolbar.blade.php Adding ID to Wrapper * Update toolbar.blade.php Adds IDs to Filter Labels Adds IDs to Filter Wrappers Restores removed EOF newline * Restoring New Line at EOF * Adding Filter Custom Pills blade option (#23) * Adding Filter Custom Pills blade option * Removing formatting changes * Get applied filters only non empty (#24) * Restrict AppliedFilters to only return non-empty At the moment, a filter will be considered "applied" if it has any value, including the default value. This causes the Pills to appear with a blank value. * Moving to withValues to make more sense * Child open attribute (#25) * Adding childElementOpen attr for all toolbar items. * Adjusting Toolbar to remove errant formatting * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Adding getAdditionalSelectRaws (#26) Using selectRaw rather than directly using DB Referencing DB directly rather than a use Fix styling Fixing test Restoring workflows Removing automated on-push Setting up configuration elements, documentation Adding parameterised capability * Update composer.json * Update run-tests.yml * Fix doc types (#27) * Update toolbar.blade.php * Update Filter.php * Update FilterHelpers.php * Fix styling * Update FilterConfiguration.php * Fix styling * Initial DocType Fixes * Fix styling * PHPDoc FIxes * Toolbar Blade Fixes for Pagination * Fix styling * Removing non-nullable return * Fixing DocType issues * Reverting minor tweaks due to PHPUnit failures * Removing PHPStan * Additional PHPDoc Fixes * Fixes for PHPDocTypes * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update composer.json * Custom pill views (#29) * Adding Filter Custom Pills blade option * Removing formatting changes * Initial Commit * Fix styling * Fix for errant line end * Fix styling * Minor Tweaks * Remove ParaTest for this branch * Restore Run-tests for this branch * Remove CustomFilterPil * Reverting Numerous Changes to Doctypes - Branches * Fix Mistaken Branch merge * More remediation to remove branch merges * Fix styling * More removals of branch merge * Adding SlideDownRow and SlideDownColspan Tests * Fix styling * Restoring original workflow * Restoring CS FIxer --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Adding test for get/set custom pills * Fix styling * Update Test * Initial Commit add filterPosition to header/footer * Fix styling * Move Labels to Blades & CustomFilterLabels * Move Labels to Blades & CustomFilterLabels * Fix styling * Add swapping for slidedown/popover for BS4/5 * Fix styling * Custom filter labels (#39) * Move Labels to Blades & CustomFilterLabels * Move Labels to Blades & CustomFilterLabels * Fix styling * Add swapping for slidedown/popover for BS4/5 * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Fix styling * Extra Tests * Fix styling * Removing duplicate method * Fix styling * Test Fixes - TypeHinting * Remove Protected Property * Property Fixes * Row/Colspan - move to string|int * Doc Updates --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding next labels:
to be used in translation for different languages