Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fetchxml conversion to c sharp to avoid collision #1030

Merged

Conversation

grasshopperhamburger
Copy link
Contributor

Hello! This is my first contribution to any public repository, so I apologize in advance for any mistakes.

The Situation:

When using this tool, some users may paste the entity logical name to easily access aliased values from the resulting collection (without appending "1" if left blank). While this method is straightforward, it poses a problem. The variable holding the link entity object will inevitably conflict because its name is the same as the early bound class (when present).

The Solution:

Without excessive engineering, a simple compare to prefix the logical name

thanks in advance

@rappen rappen merged commit b103abd into rappen:master Apr 11, 2024
@rappen
Copy link
Owner

rappen commented Apr 11, 2024

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants