Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS & C# conversion rewrite #660

Merged
merged 3 commits into from
Feb 18, 2022
Merged

JS & C# conversion rewrite #660

merged 3 commits into from
Feb 18, 2022

Conversation

MarkMpn
Copy link
Collaborator

@MarkMpn MarkMpn commented Feb 18, 2022

  • Replaced regular expressions with XmlDocument to parse the FetchXML
  • Use JSON.NET to ensure all values are correctly encoded for JavaScript

Comments and text nodes will be ignored during the JavaScript conversion, not sure if that's an issue?

Fixes #653

@rappen rappen merged commit 29e03d9 into rappen:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetchxml JavaScript code incorrect condition
2 participants