Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than 5000 views being returned. Solves #831. #833

Closed
wants to merge 1 commit into from
Closed

Support more than 5000 views being returned. Solves #831. #833

wants to merge 1 commit into from

Conversation

ryanspain
Copy link

@ryanspain ryanspain commented Dec 3, 2022

Tested locally and confirmed that both system and user views (savedquery) can return more than 5000 results.

rappen added a commit that referenced this pull request Dec 4, 2022
@rappen
Copy link
Owner

rappen commented Dec 4, 2022

Big thanks to you!

However... This is not the only place where we would get all. Like getting Market Lists, etc.
So I'll make a more general change, using the overloading in FXBQueries. Then we will keep the local logging btw.
It will need a parameter with default to "get all". When getting your query results, it should get one page at a time.

See my solution: 310a103

@rappen rappen closed this Dec 4, 2022
@ryanspain
Copy link
Author

Thanks. It makes sense to roll it out on a wider scale and maintain the logging that was in place.

Thanks for your continued maintenance of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants