Fix C# code generation for linkentities with OR root filter #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Great finding the issue and resolving it 😊🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we have noticed that when a link entitiy has its root filter set to the OR type, despite the fetchxml being correct, the generated QueryExpress C# code is not. It does not create a new filterexpression and the default one is of type AND.
This PR fixes the issue by appling the same logic used for OwnersType.Sub also for ownerType == OwnersType.Link (only when filter is of type OR and there is at least one condition).
The following screenshot shows the generated code before and after the fix: