getItemsByCreator is not working for all items from Opensea

[eduardstal]

Question Posted: 21 June 2021, in Discord

skogard#9209:

It looks like getItemsByCreator is not working for all items from Opensea. Here's an example: https://api.rarible.com/protocol/v0.1/ethereum/nft/items/byCreator?creator=0x5362d930a875560b5325663e9d90ce7310973e74

If you go to the creator's page on Rarible website, it does have items, but the API is returning empty array: https://rarible.com/user/0x5362d930a875560b5325663e9d90ce7310973e74?tab=created

Same happens for all other Opensea NFTs. Not sure if this is just for Opensea or for any non-rarible NFTs....

QUESTION #2: Does the protocol allow people to create sell orders that only a specific address can buy? I thought this was possible by setting the "taker" attribute. Here's the payload:

{
  "type": "RARIBLE_V2",
  "maker": "0xfb7b2717f7a2a30b42e21cef03dd0fc76ef761e9",
  "make": {
    "assetType": {
      "assetClass": "ERC721",
      "contract": "0xB0EA149212Eb707a1E5FC1D2d3fD318a8d94cf05",
      "tokenId": "113748116997632943908989974912943551603774609216661645898176697017925860589624"
    },
    "value": "1"
  },
  "take": {
    "assetType": {
      "assetClass": "ETH"
    },
    "value": "100000000000000000000"
  },
  "data": {
    "dataType": "RARIBLE_V2_DATA_V1",
    "payouts": [],
    "originFees": []
  },
  "salt": "162417726603365384",
  "taker": "0xfb7b2717f7a2a30b42e21cef03dd0fc76ef761e9",
  "signature": "0x4601556ad98c834912a3ec399dd448dad7b263bef04811af53747a4c37dc69f1088d5d5abb2c1cdd28bf1856b38fd06037dcbcbb13ab95b132e8a7c6517b99051c"
}

After submitting the order to the API, I looked at the order item

https://api-dev.rarible.com/protocol/v0.1/ethereum/order/orders/sell/byItem?contract=0xB0EA149212Eb707a1E5FC1D2d3fD318a8d94cf05&tokenId=113748116997632943908989974912943551603774609216661645898176697017925860589624

and I can see the taker attribute, but not sure if this means it's working as intended (only that address can purchase the listing), since the Rarible website UI doesn't display that information.(edited)

// Question #3: I've been trying to get the start and end attributes to work for making orders, but can't seem to get it to work. Here's the payload I posted:

{
  "type": "RARIBLE_V2",
  "maker": "0xfb7b2717f7a2a30b42e21cef03dd0fc76ef761e9",
  "make": {
    "assetType": {
      "assetClass": "ERC721",
      "contract": "0x6ede7f3c26975aad32a475e1021d8f6f39c89d82",
      "tokenId": "113748116997632943908989974912943551603774609216661645898176697017925860590218"
    },
    "value": "1"
  },
  "take": {
    "assetType": {
      "assetClass": "ETH"
    },
    "value": "1000000000000000000"
  },
  "data": {
    "dataType": "RARIBLE_V2_DATA_V1",
    "payouts": [],
    "originFees": []
  },
  "salt": "162416691063970203",
  "end": 1624253310639,
  "signature": "0x291712d9480785ebdb2102ac4226c5aa72acba3ee5f02f523993cc2dd78d41e7210aae2349badc8c1e7c2fc0c3ed07fd30784cf84efde93c7a2ae5f5e19e031f1b"
}

Maybe I'm doing something wrong. Aren't theu unix timestamps? As you can see, I've included 1624253310639 as the end attribute. After posting above payload, I go to the API and check the corresponding order item:

https://api-staging.rarible.com/protocol/v0.1/ethereum/order/orders/sell/byItem?contract=0x6ede7f3c26975aad32a475e1021d8f6f39c89d82&tokenId=113748116997632943908989974912943551603774609216661645898176697017925860590218

but I don't see the "end" attribute.

izkp#1401:

2 - that is indeed what taker is for. Did you test filling the order? That may still need to be added to the UI

3 - yes that should work. Need to confirm that this is the correct precision for the time stamp. Looks right at a glance but not able to confirm at the moment. Also haven’t tested that so I will try and report back

Eugene Nacu | Rarible#9332:

@isaac @skogard

1. Taker is the right field
2. Start and end are too. Precision is in seconds

But, these fields currently are not shown on rarible UI.

skogard#9209:

could you share a working example for the "start" and "end"? I've tried all of milliseconds, microseconds and seconds options and even minutes. Couldnt't get any of them to work. I don't expect them to show up on the Rarible UI, they are simply not included in the order API.

Here's an example:

https://api-dev.rarible.com/protocol/v0.1/ethereum/order/orders/sell/byItem?contract=0xB0EA149212Eb707a1E5FC1D2d3fD318a8d94cf05&tokenId=113748116997632943908989974912943551603774609216661645898176697017925860589626

Also, maybe I'm misinterpreting what these fields are. If it's not unix timestamp and you said the precision is in seconds, maybe it is not even about unix timestamp? Do start and end mean the relative time elapsed from the point I submit the order? For example, if i submit "start": 60 does it mean it starts in 60 seconds? I just assumed it was absolute time.

Eugene Nacu | Rarible#9332:

Quoted: "It looks like getItemsByCreator is not working for all items"

Yes, thanks for the issue. Will fix this. Created an issue

skogard#9209:

I don’t know what I’m doing wrong with the order request. Here’s what I submit:

{
  type: 'RARIBLE_V2',
  make: {
    assetType: {
      assetClass: 'ERC1155',
      tokenId: '52103307166765014994970427877263908096137622415883594758114461278185103294497',
      contract: '0x6a94aC200342AC823F909F142a65232E2f052183'
    },
    value: '17'
  },
  take: { assetType: { assetClass: 'ETH' }, value: '100000000000000000000' },
  data: { dataType: 'RARIBLE_V2_DATA_V1', payouts: [], originFees: [] },
  salt: '162501385058932757',
  maker: '0x73316d4224263496201c3420b36cdda9c0249574',
  signature: '0xffba6c94c9321bfc04d31a494c1397299e59c3f731dac7794594444a2cdffde143147ed1555f0f7e0998ee1c8d931bbc783c83076444d285a9ece1102d5030d61c'
}

The error message I'm getting is: "Failed to convert from type [java.math.BigDecimal] to type [org.bson.types.Decimal128] for value '12848.0862187168335294117647058823529'; nested exception is java.lang.NumberFormatException: Conversion to Decimal128 would require inexact rounding of 12848.0862187168335294117647058823529"

Eugene Nacu | Rarible#9332:

This is a bug, I think,
I will check this

Is this on mainnet?
Also, it will be helpful if you give me curl with this request failing

skogard#9209:

I've been testing on rinkeby and ropsten because I didn't yet want to spam the mainnet with too many NFTs. What's weird is, it suddenly started working even though I didn't change the code, and it's not been working for at least a couple of days. Did someone at the team see my message and fix it?

Eugene Nacu | Rarible#9332:

I can see why this happens (we need to round some value stored in db, we don't currently). Anyway, I created an issue

thanks for the submission

As it works for you, I won't set it super high priority, so should be fixed next week

[eduardstal]

Since we need to group and filter the discussions page, I'll be adding this reply as an answer since these kinds of threads(from discord) won't have activity any time soon.