RoyaltiesV2, upgraded solidity to 0.8 and it doesn't work

[eduardstal]

Question Posted: 11 August 2021, in Discord

tomw1808#2136:

hey @eugene Nacu | Rarible if you could tell me what's going on here it would be super helpful. We implemented the RoyaltiesV2 from your github - but upgraded it to Solidity 0.8 - tried it and somehow it doesn't work.

https://rinkeby.etherscan.io/tx/0x951bcc73e1f26616eeed84e4cdbab926964e447eacf9330a5230fd8fd07d201c

Eugene Nacu | Rarible#9332:

Could you share contract code too?

tomw1808#2136:

well that's a bummer, because we were debugging and trying for the last 4 days without any much of a help. I'm going to be afk for the next two days and we already delayed our first action by a few days

@eugene Nacu | Rarible can you just let me briefly know: if a tuple is returned for "getRoyalties" it should be enough including the right ERC165 supportsInterface?

like here:

https://rinkeby.etherscan.io/address/0x48c4a78e73994e6d350eb78f197a9408be103b07#readContract

for token #0

Eugene Nacu | Rarible#9332:

should be fine yes

tomw1808#2136:

and its expected that it doesn't work on rinkeby?

I mean, the contracts from mainnet and rinkeby are different? It's a bit hard to follow with the proxies in place

Eugene Nacu | Rarible#9332:

Are the same

tomw1808#2136:

ok, weird

but yeah, thanks so much for looking into it so late.

any idea why your contracts take out 2.5% twice?

that looks kinda odd, does it?

Eugene Nacu | Rarible#9332:

We will update docs about fees like tomorrow. 2.5% two times is ok. one time for each order

[eduardstal]

Since we need to group and filter the discussions page, I'll be adding this reply as an answer since these kinds of threads(from discord) won't have activity any time soon.