Add undefined type to opt_b and opt_c in patch_make() #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rars
approved these changes
Jun 1, 2024
rars
requested changes
Jun 1, 2024
src/diff-match-patch.class.ts
Outdated
| @@ -457,8 +457,8 @@ export class DiffMatchPatch { | |||
| */ | |||
| public patch_make( | |||
| a: string | Diff[], | |||
| opt_b: string | Diff[], | |||
| opt_c: string | Diff[], | |||
| opt_b: string | Diff[] | undefined, | |||
There was a problem hiding this comment.
Shall we change these to optional arguments so that we can call patch_make with 1 or 2 parameters (e.g. patch_make(text1)) and avoid requiring explicit undefined values being passed (i.e. patch_make(text1, undefined, undefined))?
Suggested change
| opt_b: string | Diff[] | undefined, | |
| opt_b?: string | Diff[], |
|
hey sorry about the delay, switched them to optional arguments per your suggestion |
rars
approved these changes
Jun 17, 2024
|
Thanks @thyme4soup, this has been released in https://github.com/rars/diff-match-patch-ts/releases/tag/v0.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, first off thank you so much for this library
I'm trying to use patch_make() and running into an issue when compiling my typescript where to use method 2 of patch_make you need to pass 'undefined'. I'm able to get around this by either not passing the opt_c argument or ignoring the error and setting it to 'undefined,' but it fails when building in github workflow
I think just adding 'undefined' to the allowed types would do it