-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in initial project setup for actions running via rasa or via sdk #5368
Comments
@erohmensing are you working on this atm? if not, please unassign |
I'd agree, let's change the default project (
I think there might be a |
@erohmensing Imo this needs to go in before the RC next week. Do you have this on your radar or should our squad take this over? |
i'm gonna speak for our team and say that we are slammed with customers + 2.0 docs at the moment, so it'd be nice if your squad takes it :) |
@alwx @tczekajlo is it ok for you if we take on this time critical task? Rick is also back onboard then, so I think we do this despite our decoupling commitment |
I'm ok with that, not sure If I'm the best person to do this if it's time-critical task though 😄 |
It's time critical in a sense that it should be done until next week. I'll add it to our board. |
reminder to update the CLI documentation and others on initial project setup |
Currently, when running an action server with
rasa run actions
, the default looks inactions.py
in the base of your project directory.actions.py
is created there as part of the initial project.However, if you build in docker, the default place to find actions is in
actions/actions.py
. https://github.com/RasaHQ/rasa-sdk/blob/master/Dockerfile#L40This makes it confusing -- when teaching the user to create custom actions in Docker, we have to tell them to create the new folder with an actions file, when
actions.py
already exists: https://rasa.com/docs/rasa/user-guide/how-to-deploy/#creating-a-custom-actionThis seems to also have caused confusion here: RasaHQ/rasa-sdk#140 (comment)
We should make the default behavior consistent. I'm partial to having an
actions
folder as it's probably quite normal for a larger actions file to reference other files. However that will probably involve changing a decent amount of references in e.g. tutorials.The text was updated successfully, but these errors were encountered: