Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send potential ActionExecutionRejected after form validation #6977

Closed
wochinge opened this issue Oct 9, 2020 · 1 comment · Fixed by #7035
Closed

Send potential ActionExecutionRejected after form validation #6977

wochinge opened this issue Oct 9, 2020 · 1 comment · Fixed by #7035
Assignees
@wochinge
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
2.1 Rasa Open Source

Comments

@wochinge
Copy link
Contributor

wochinge commented Oct 9, 2020

The FormAction currently returns an ActionExecutionRejected event in case there were no slot candidates extracted (see here).
The problem is that with Rasa Open Source 2.0 users can extract custom slots in their custom validate action. In case they only extract slots manually, it currently throws a ActionExecutionRejected. Instead it should run the custom validate function and decide then whether a ActionExecutionRejected event should be returned.

Notes by @Ghostvv

we need to think how custom vs default validation works and how to notify form through custom validation action
@wochinge wochinge added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework priority:high labels Oct 9, 2020
@wochinge wochinge added this to the 2.1 Rasa Open Source milestone Oct 9, 2020
@ArjaanBuijk
Copy link
Contributor

ArjaanBuijk commented Oct 9, 2020 •
edited
Loading

I tried to use ActionExecutionRejected for implementing some logic, but got stuck because it is not possible to set slots at the same time. I needed the slots for use in a rule and the next action.

It would be a good enhancement I think to allow to set slots.

@wochinge wochinge self-assigned this Oct 12, 2020
@wochinge wochinge mentioned this issue Oct 16, 2020
Merged
4 tasks
@humcasma humcasma mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wochinge wochinge

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
2.1 Rasa Open Source
2 participants
@wochinge @ArjaanBuijk