Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poc bandit #7284

Merged
merged 22 commits into from
Dec 10, 2020
Merged

Poc bandit #7284

merged 22 commits into from
Dec 10, 2020

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented Nov 16, 2020 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

m-vdb
m-vdb commented Nov 20, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
m-vdb
m-vdb commented Nov 20, 2020
View reviewed changes
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
@m-vdb m-vdb requested review from tczekajlo and joejuzl November 20, 2020 14:49
@m-vdb m-vdb added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss/infrastructure 🚅 All things related to infrastructure or deployments labels Nov 20, 2020
joejuzl
joejuzl reviewed Nov 20, 2020
View reviewed changes
.github/workflows/security-scans.yml Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
@m-vdb m-vdb requested review from wochinge and joejuzl and removed request for tczekajlo November 30, 2020 17:29
@tmbo
Copy link
Member

tmbo commented Dec 8, 2020

@m-vdb should we get this merged or is there something we need to test first?

@m-vdb
Copy link
Collaborator Author

m-vdb commented Dec 8, 2020

I wanted to get input from @wochinge as well. I know he didn't have the time last week, hopefully he's able to do a review this week 🤞🏻

wochinge
wochinge approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review 😬

Thanks for taking this on 🚀

Makefile Outdated Show resolved Hide resolved
bandit.yml Outdated Show resolved Hide resolved
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
m-vdb
m-vdb commented Dec 9, 2020
View reviewed changes
bandit.yml Outdated Show resolved Hide resolved
@m-vdb m-vdb requested a review from a team December 9, 2020 10:49
@m-vdb m-vdb merged commit fb09c6b into master Dec 10, 2020
@m-vdb m-vdb deleted the poc-bandit branch December 10, 2020 09:55
@wochinge wochinge mentioned this pull request Dec 17, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

@joejuzl joejuzl joejuzl approved these changes

Assignees
No one assigned
Labels
area:rasa-oss/infrastructure 🚅 All things related to infrastructure or deployments type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-vdb @tmbo @joejuzl @wochinge