Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.8's new metadata package #56

Closed
rasbt opened this issue Oct 20, 2019 · 0 comments · Fixed by #66
Closed

Python 3.8's new metadata package #56

rasbt opened this issue Oct 20, 2019 · 0 comments · Fixed by #66

Comments

@rasbt
Copy link
Owner

rasbt commented Oct 20, 2019

It looks like Python 3.8's new metadata package in the standard lib could be useful for getting package versions more reliably if someone is on Python 3.8.

reference: https://docs.python.org/3/library/importlib.metadata.html
@rasbt rasbt mentioned this issue Dec 26, 2019
Open
@jamesmyatt jamesmyatt mentioned this issue Oct 29, 2020
Merged
@rasbt rasbt closed this as completed in #66 Nov 20, 2020
rasbt pushed a commit that referenced this issue Nov 20, 2020
@jamesmyatt
importlib-related improvements (#66)
9cbbcb5 
* Use importlib.import_module
As recommended in docs: https://docs.python.org/3/library/importlib.html#importlib.__import__

* Use importlib.metadata rather than pkg_resources
As recommended in option 5: https://packaging.python.org/guides/single-sourcing-package-version/
Closes #56

* Use importlib-metadata for own version

* Update readme

* Fix minor formatting errors using isort and black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

importlib-related improvements
1 participant
@rasbt