Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small PR to introduce support for a hardware target reset.
Asserting and de-asserting the reset signal is controlled by a new probe USB command:
https://github.com/newbrain/picoprobe/blob/5f1630c390fbb912b625231d6c02fb7b3b538b27/src/probe.c#L76
If the value passed in the bits command header is false (0) the reset line is de-asserted (high).
If true (anything else) the reset line is asserted (low).
The reset pin is configured in
picoprobe_config.h
, currently GPIO 6:https://github.com/newbrain/picoprobe/blob/5f1630c390fbb912b625231d6c02fb7b3b538b27/src/picoprobe_config.h#L55-L56
Open drain is simulated changing the pin direction from output (for low) to input (for high, with pull-up)
This can be easily added to OpenOCD, and I'll include it in pyOCD when I propose the picoprobe support PR.
Tested with a modified pyOCD and a scope.