Skip to content

Commit

Permalink
drm/vc4: Limit fkms to modes <= 85Hz
Browse files Browse the repository at this point in the history
Selecting 1080p100 and 120 has very limited gain, but don't want
to block VGA85 and similar.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
  • Loading branch information
6by9 authored and popcornmix committed Jun 20, 2019
1 parent cbb5c28 commit 883a1a5
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/gpu/drm/vc4/vc4_firmware_kms.c
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,10 @@ vc4_crtc_mode_valid(struct drm_crtc *crtc, const struct drm_display_mode *mode)
return MODE_NO_DBLESCAN;
}

/* Disable refresh rates > 85Hz as limited gain from them */
if (drm_mode_vrefresh(mode) > 85)
return MODE_BAD_VVALUE;

/* Limit the pixel clock based on the HDMI clock limits from the
* firmware
*/
Expand Down

1 comment on commit 883a1a5

@alanbork
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why exactly is this a good idea? If the user wants to select 120hz refresh mode why try to defeat them?

Please sign in to comment.