overlays: wm8960-soundcard: Fix clock declaration #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How did this ever work? The static-clock declaration is fine, but the reference to it is attached to part of the simple-audio-card node, rather than the instantiation of the codec driver (a subnode of the I2C controller). Move the clock reference where it should be, and fix a few minor cosmetic issues at the same time. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
|
I can confirm that this pull request fixes audio playback on wm8960, previously |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 26, 2024
See: raspberrypi/linux#6368 kernel: tty/serial: pl011: Also unregister pl011_axi_platform_driver See: raspberrypi/linux#6380 kernel: overlays: wm8960-soundcard: Fix clock declaration See: raspberrypi/linux#6387 kernel: Fix speaker disabling issue after closing microphone app See: raspberrypi/linux#6383 kernel: ASoC: bcm2835-i2s: Set the PERIOD_BYTES min to 256 See: raspberrypi/linux#6386 kernel: drivers: media: imx500: Simplify the vblank control init See: raspberrypi/linux#6388
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Sep 26, 2024
See: raspberrypi/linux#6368 kernel: tty/serial: pl011: Also unregister pl011_axi_platform_driver See: raspberrypi/linux#6380 kernel: overlays: wm8960-soundcard: Fix clock declaration See: raspberrypi/linux#6387 kernel: Fix speaker disabling issue after closing microphone app See: raspberrypi/linux#6383 kernel: ASoC: bcm2835-i2s: Set the PERIOD_BYTES min to 256 See: raspberrypi/linux#6386 kernel: drivers: media: imx500: Simplify the vblank control init See: raspberrypi/linux#6388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How did this ever work? The static-clock declaration is fine, but the reference to it is attached to part of the simple-audio-card node, rather than the instantiation of the codec driver (a subnode of the I2C controller).
Move the clock reference where it should be, and fix a few minor cosmetic issues at the same time.