Do not always set stdin to FNONBLOCK when PICO_PLATFORM=host #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarnota
force-pushed
the
make-stdio-functions-blocking-in-platform-host
branch
from
c30e392
to
1c807ae
Compare
Because the UART simulation was setting FNONBLOCK flag on stdin, all stdio functions like scanf() or fgets() were non blocking. The workaround is to use a non_blocking_getchar() function to do the UART simulation, which will temporarily set stdin to non blocking. This will make stdio functions blocking like they normally do.
czarnota
force-pushed
the
make-stdio-functions-blocking-in-platform-host
branch
from
1c807ae
to
d3cb972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I compile project with
PICO_PLATFORM=host, then functions likescanf()andfgets()do not block anymore. They are blocking on the actual board, so I would expect them to also block when compiled withPICO_PLATFORM=host.The solution I came up with is to only enable non-blocking input when
_peekchar()is called.